master: Update pkg/testutils/release/cockroach_releases.yaml#167505
Conversation
cockroach-teamcity
force-pushed
the
crdb-releases-yaml-update-master
branch
from
169c65a to
184815c
Compare
|
😎 Merged successfully - details. |
|
This change is |
cockroach-teamcity
force-pushed
the
crdb-releases-yaml-update-master
branch
3 times, most recently
from
a646173 to
6bcd962
Compare
celiala
left a comment
celiala
left a comment
There was a problem hiding this comment.
I can't remember if we're clear to bump predecessor yet from 26.1 to 26.2
let's hold on this until I can verify the pkg/clusterversion/ runbooks.
Update pkg/testutils/release/cockroach_releases.yaml with recent values. Epic: None Release note: None Release justification: test-only updates
cockroach-teamcity
force-pushed
the
crdb-releases-yaml-update-master
branch
from
6bcd962 to
0e210c5
Compare
|
@celiala can you review this one? |
| predecessor: "26.1" | ||
| "26.3": | ||
| predecessor: "26.1" | ||
| predecessor: "26.2" |
There was a problem hiding this comment.
I can't remember if we can do this update yet (it depends on where we are in the M.x tasks)
lemme take a look in a bit
There was a problem hiding this comment.
After digging into the code: this update is safe to do at any time, regardless of where we are in the M.x cycle.
Why: predecessorSeries() in pkg/testutils/release/releases.go already skips unreleased series (those with empty Latest) when walking the predecessor chain. So setting predecessor: "26.2" now — even though 26.2 has no release yet — produces identical runtime behavior to predecessor: "26.1". The code would just skip 26.2 and fall through to 26.1 either way.
There's even an explicit test case for this: "skips unreleased predecessor" in releases_test.go.
The M.1 runbook currently directs the operator to use series-2 (instead of series-1) as a temporary measure, saying it will be corrected in M.3. That guidance is unnecessary — series-1 is always safe. We'll update the runbook in a follow-up PR.
3 participants
Update pkg/testutils/release/cockroach_releases.yaml with recent values.
Epic: None
Release note: None
Release justification: test-only updates